Several fixes to processing of cross-sections

shartgring commented 1 week ago

Issue addressed

Fixes #145 #146 and adds new functionality

Explanation

I have included the code related to cross-sections from Santa Cruz branch, and also some other additional functionalities and fixes.

Checklist

[X] Updated tests or added new tests
[X] Branch is up to date with main
[X] Tests & pre-commit hooks pass
[X] Updated documentation if needed
[X] Updated changelog.rst if needed

Additional Notes (optional)

I also copied some code for 'special' cross-sections from Santa Cruz; I am not sure what that refers to to be honest. Maybe leave that out / make an issue for additional functionality where we temporary store the code?

The tests still pass, I had to include reset_index which I did not particularly liked as the local test build failed due to a pandas error (index and column both had name crs_id).

I also spend quite some time on a test for one of the cross-section workflows. I think we can use it as a template to test the other cross-section types when we have (hopefully) more time in the future to tidy things up.

shartgring commented 1 week ago

Ai I see a test is failing now. Maybe because I added the maxdist variable last-minute. Will explore and fix it.

EDIT: The tests on my machine in VS code work fine. Seems to be related to hydromt, can pytest on github access the hydromt data?

shartgring commented 1 week ago

Testing works again and tests passed succesfully :)