Closed veenstrajelmer closed 6 days ago
I kind of supposed some of the calls depend on calls that were done before right? I agree it is a bit bulky, but I think the only good alternative is adding proper+quick unit tests for everything, which would take more time to create than what I did here. And for now, this already helps significantly with debugging code.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Issue addressed
Fixes #135
Explanation
Added python code versions of the build-model testcases and then debugging the geopandas v1 errors was easy. I have excluded v1.0.0 because of https://github.com/geopandas/geopandas/issues/352, but this is resolved in 1.0.1. There was only one edit needed, since
gpd.sjoin()
is not possible anymore if the index name is the same as a column name. I expect this is a bug in geopandas, which we might want to report if it is a problem for us. I can also imagine this does not matter at all, so in that case we can leave it.Checklist
main