Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
7 stars 1 forks source link

Migrate to hydromt v1 #162

Open veenstrajelmer opened 6 days ago

veenstrajelmer commented 6 days ago

Issue addressed

Fixes #137

Explanation

Since hydromt v1 is now officially out, I think it is wise to update to that new code. This will avoid dependency issues in the future. The API's are quite different so I have a bit of trouble with converting the code.

What I did:

According to the migration manual, I think Model should have a logger instance. This does not seem to be the case since this also raises KeyError: 'logger':

from hydromt.model import Model
mod = Model()
mod.logger

Checklist

sonarcloud[bot] commented 6 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint