Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
7 stars 1 forks source link

Fixes related to structures #169

Open shartgring opened 3 days ago

shartgring commented 3 days ago

Issue addressed

Fixes #141 and some other small things

Explanation

Again, several bugfixes applied in the Santa Cruz branch, mostly related to duplicate structures and compound structures. This PR contains those fixes, and also some new tests for bridges and culverts.

Checklist

Additional Notes

It currently does not include test cases checking if duplicate and compound structures are handled well which is something to include. For this, I think it can be a test only for the workflow and not the setup_methods which are already covered by the two new tests.

When developing the tests, I ran into some trouble, see https://github.com/Deltares/hydromt_delft3dfm/issues/168 . This is addressed by also calling setup_channels in the test as a workaround, as I think this issue is too large to fit in this PR. I've included links to the issues in the tests as a reminder for us, and will also link the tests in the issue itself

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud