Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
9 stars 2 forks source link

Piave test add rainfall #199

Closed veenstrajelmer closed 1 month ago

veenstrajelmer commented 1 month ago

Issue addressed

Fixes #177

Explanation

The last step in syncing the models in the examples and the tests/data folders. To do this, I have added rainfall to the piave model in tests and updated the expected output model accordingly. I have also renamed the piave build yml to contain "piave", just because I found it confusing it did not before.

As a last step, I wanted to remove the redundant yml files in tests/data and instead use the yml files from examples in the tests. This to avoid we have to keep syncing them upon every change. Makes more sense to me. However, I noticed that the paths in test_data.yml are in fact relative to the build yml and not relevant to the test_data.yml, so this caused the build of the local model to fail. I could fix this by moving all example build yml's and the local test data to examples/data (then the build and datacatalog yml's are in the same folder), which kind of makes sense. But I wanted to discuss this first. At the moment I think this PR is also an improvement since the build yml's are now at least completely aligned, some filenames are now more clear (at least to me) and I also removed unused build files.

Checklist

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud