hboisgon
commented
1 year ago @DirkEilander : this PR/issues were on you but I needed them earlier than what I thought for a project :) The basin index issue was indeed a problem so this is fixed and I removed the error is crs was not 4326. All the rest seem to work fine!
So still to do is:
- [x] In setup_basemaps, implement a check for if the coordinate system is projected or geographic. If projected need to update the TOML file for model.sizeinmetres = true !! Else you get a very criptic wflow error.....
- [x] Notebook to prepare from elevation flwdir/uparea/basins/strord
- [x] Docs / changelog / test? Would be nice to include test case as for eg coordinates for basin in region need to be in the DEM crs etc.
Support local DEM data and add notebook on examples how to create flwdir/uparea/strord based on elevation.