Update methods around gauges

Deltares / hydromt_wflow

Wflow plugin for HydroMT

https://deltares.github.io/hydromt_wflow/

GNU General Public License v3.0

18 stars 15 forks source link

Update methods around gauges #172

Closed hboisgon closed 1 year ago

hboisgon commented 1 year ago

Based on several open issues, this PR contains several changes associated to gauges:

split setup gauges and outlets in different setup methods #170
add a create_gauge method to add gauge directly from a gpd.GeoDataFrame
add a setup_config_output_timeseries to be more flexible in adding new varibale/column for netdcf/csv sections of toml
updates on how to derive outlets fixes #76
support gauge data type geodataset fixes #85
support changing snapping distance fixes #68
support snapping gauges based on upstream area fixes #170
add unit test #76

hboisgon commented 1 year ago

I think this PR is more or less ready to be merged. Because I added a new create_gauges method, I wonder if we include it in the next release or wait for this issue to be fixed in hydromt core before merging: https://github.com/Deltares/hydromt/issues/312

hboisgon commented 1 year ago

Hi @laurenebouaziz ! Thanks a lot for the review! I added better docstrings, you were absolutely right :) and I answered some of your questions here too. Could you re-review and see if the changes I made are good?

laurenebouaziz commented 1 year ago

thanks @hboisgon for the clear docstrings and all the explanations to the questions I had, all clear to me. Apart from the last tiny comment, I think it is good to merge!