search

Deltares / hydromt_wflow

Wflow plugin for HydroMT
https://deltares.github.io/hydromt_wflow/
GNU General Public License v3.0
18 stars 15 forks source link

Rootzone clim #184

Closed laurenebouaziz closed 1 year ago

laurenebouaziz commented 1 year ago

implement an alternative way to calculate the rootingdepth for wflow_sbm based on hydrometeorological data (for historical and future conditions), which follows the workflow described in Bouaziz et al. 2022.

Bouaziz, L. J. E., Aalbers, E. E., Weerts, A. H., Hegnauer, M., Buiteveld, H., Lammersen, R., Stam, J., Sprokkereef, E., Savenije, H. H. G., and Hrachowitz, M.: Ecosystem adaptation to climate change: the sensitivity of hydrological predictions to time-dynamic model parameters, Hydrol. Earth Syst. Sci., 26, 1295–1318, https://doi.org/10.5194/hess-26-1295-2022, 2022.

laurenebouaziz commented 1 year ago

thanks a lot @hboisgon for your review! I made the changes (mostly more details and corrections in the docstrings and expansion of the test), could you have another look? I also updated the changelog and api.rst, do more documentation files need to be updated?

hboisgon commented 1 year ago

thanks a lot @hboisgon for your review! I made the changes (mostly more details and corrections in the docstrings and expansion of the test), could you have another look? I also updated the changelog and api.rst, do more documentation files need to be updated?

Thanks! And yes also the table in docs/user_guide/wflow_model_setup.rst (which apparently is currently broken on the docs page...)

laurenebouaziz commented 1 year ago

thanks @hboisgon for all the suggestions and quick review! you can see all the new changes in aebd01fbb5581b76a62cb7b9cb19c36e6ccded4d

(I did not yet run black and merge main to keep the files changed readable)