search

Deltares / hydromt_wflow

Wflow plugin for HydroMT
https://deltares.github.io/hydromt_wflow/
GNU General Public License v3.0
16 stars 13 forks source link

Smoothing of river parameters #196

Open hboisgon opened 1 year ago

hboisgon commented 1 year ago

I did some checks on the the river parameters we estimate for river slope / width /depth and found some issues and/or wishes.

  1. For river slope, we can decide to compute slope over a different length with slope_len but actually smoothing is not yet possible. Would be nice to have, as in kinematic wave, water levels and volumes are very very strongly dependent on river slope values. Would also be nice to add a minimum value for slope, as the default one is zero and the one in Wflow.jl can sometimes be too low.
  2. River width and depth: there should be smoothing, but I actually found a bug (should be max instead of min):

https://github.com/Deltares/hydromt_wflow/blob/5e59664b20906422b1e4fefc8d1090a8783ef920/hydromt_wflow/workflows/river.py#L269-L271

  1. To prepare width and depth, we can use values from a river geometry file (like Lin or HydroAtlas). However, in these databases, smaller rivers are very often not included and it can happen that along a river stretch, some portions will have values, then no data, then values again. Or currently, when filling nodata gaps, we use a constant value (eg 1 meter), so the case can happen that along a river, the depth can be around 3 meters then 1 meter in the nodata gap, then back to 3-4 meters when we have data again... Might be nice if possible to add a sort of interpolation method to fill in these nodata gaps (especially on qbankfull which is used for computing depth).