Marina pilot - Githubissues

Deltares / hydromt_wflow

Wflow plugin for HydroMT

https://deltares.github.io/hydromt_wflow/

GNU General Public License v3.0

16 stars 13 forks source link

Marina pilot #209

Closed hboisgon closed 8 months ago

hboisgon commented 10 months ago

Issue addressed

I did not publish specific issues for these.

Explanation

This branch started with another goal so I will split and do 2 PRs. In this branch I focus on some bugfixing and better support of local data:

setup_rivers: if river depth is in the input rivers_fn then use it rather than compute from qbankfull
setup_reservoirs: bugfixes on required columns to better match what is in the docs
setup_lulcmaps: bugfix to read the mapping_table_fn
setup_config_output_timeseries: bugfix if reducer is provided

Checklist

[x] Updated tests or added new tests
[x] Branch is up to date with main
[x] Tests & pre-commit hooks pass
[x] Updated documentation if needed

hboisgon commented 10 months ago

Tests are failing with new hydromt 0.9.0