Water demand - Githubissues

Deltares / hydromt_wflow

Wflow plugin for HydroMT

https://deltares.github.io/hydromt_wflow/

GNU General Public License v3.0

20 stars 15 forks source link

Water demand #226

Closed dalmijn closed 3 weeks ago

dalmijn commented 1 year ago

Issue addressed

Fixes #87

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

[ ] Updated tests or added new tests
[ ] Branch is up to date with main
[ ] Tests & pre-commit hooks pass
[ ] Updated documentation if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

verseve commented 9 months ago

Thanks for adding irrigation and crop factor maps @JoostBuitink !

For a test version I think it would be good to also add a soil profile for irrigated paddy areas: kvfrac and thickness of soil layers. See also https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1807919657. A 15/20 cm topsoil and 5/10 cm plow pan (low hydraulic conductivity, e.g. 5 mm/day) is probably fine. Might be good to support different profiles in Wflow.jl (and hydromt_wflow) (refinement).

JoostBuitink commented 7 months ago

ToDo's still open:

[ ] Address review comments (non-irrigation)
[x] Add complete docstrings to the new functions, and check existing docstrings for completeness
[x] Add tests
[x] Add functions to docs/API reference
[x] Add example notebook

verseve commented 6 months ago

Nice work!

A few comments/suggestions:

For the paddy areas I think it would be nice if a user can set the parameters h_min, h_max and h_opt, see also https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1807919657.
For paddy areas the critical pressure heads can be set in hydromt_wflow, see also https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1254709648.
It would be nice if alpha_h1 could be set based on crop info. This information is also useful without running water demand and allocation in wflow.

verseve commented 6 months ago

Hi @JoostBuitink and @dalmijn, with the wflow piave test model only surface water is allocated to satisfy the water demand. This is caused by the default value (1.0) of frac_sw_used (fraction surface water used) and sufficient surface water availability. This does not seem very realistic in my opinion. I think it would be good to include a (simple) method to estimate the parameter frac_sw_used as part of this PR.

JoostBuitink commented 6 months ago

Hi @JoostBuitink and @dalmijn, with the wflow piave test model only surface water is allocated to satisfy the water demand. This is caused by the default value (1.0) of frac_sw_used (fraction surface water used) and sufficient surface water availability. This does not seem very realistic in my opinion. I think it would be good to include a (simple) method to estimate the parameter frac_sw_used as part of this PR.

That is a good suggestion! Would it make more sense (at least for now, to keep it simple) to have a value per grid cell or per allocation area?

dalmijn commented 6 months ago

@verseve would something simple based on streamorder and distance from the river suffice? This would entail that it would than be on a gridcell basis.

verseve commented 6 months ago

That is a good suggestion! Would it make more sense (at least for now, to keep it simple) to have a value per grid cell or per allocation area?

@verseve would something simple based on streamorder and distance from the river suffice? This would entail that it would than be on a gridcell basis.

I think at the grid cell would be best (similar to other hydrological models that include water demand and allocation). Two possible approaches are described in issue https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1822365438. The LISFLOOD approach seems to me the least amount of work, we could even use their input parameters maps for this (it that is allowed).