Open dalmijn opened 9 months ago
Thanks for adding irrigation and crop factor maps @JoostBuitink !
For a test version I think it would be good to also add a soil profile for irrigated paddy areas: kvfrac
and thickness of soil layers. See also https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1807919657. A 15/20 cm topsoil and 5/10 cm plow pan (low hydraulic conductivity, e.g. 5 mm/day) is probably fine. Might be good to support different profiles in Wflow.jl (and hydromt_wflow) (refinement).
ToDo's still open:
Nice work!
A few comments/suggestions:
h_min
, h_max
and h_opt
, see also https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1807919657.alpha_h1
could be set based on crop info. This information is also useful without running water demand and allocation in wflow.Hi @JoostBuitink and @dalmijn, with the wflow piave test model only surface water is allocated to satisfy the water demand. This is caused by the default value (1.0) of frac_sw_used
(fraction surface water used) and sufficient surface water availability. This does not seem very realistic in my opinion. I think it would be good to include a (simple) method to estimate the parameter frac_sw_used
as part of this PR.
Hi @JoostBuitink and @dalmijn, with the wflow piave test model only surface water is allocated to satisfy the water demand. This is caused by the default value (1.0) of
frac_sw_used
(fraction surface water used) and sufficient surface water availability. This does not seem very realistic in my opinion. I think it would be good to include a (simple) method to estimate the parameterfrac_sw_used
as part of this PR.
That is a good suggestion! Would it make more sense (at least for now, to keep it simple) to have a value per grid cell or per allocation area?
@verseve would something simple based on streamorder and distance from the river suffice? This would entail that it would than be on a gridcell basis.
That is a good suggestion! Would it make more sense (at least for now, to keep it simple) to have a value per grid cell or per allocation area?
@verseve would something simple based on streamorder and distance from the river suffice? This would entail that it would than be on a gridcell basis.
I think at the grid cell would be best (similar to other hydrological models that include water demand and allocation). Two possible approaches are described in issue https://github.com/Deltares/hydromt_wflow/issues/87#issuecomment-1822365438. The LISFLOOD approach seems to me the least amount of work, we could even use their input parameters maps for this (it that is allowed).
Issue addressed
Fixes #87
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.