search

Deltares / hydromt_wflow

Wflow plugin for HydroMT
https://deltares.github.io/hydromt_wflow/
GNU General Public License v3.0
16 stars 13 forks source link

Implement NoDataStrategy to deal with optional setup_functions #229

Closed JoostBuitink closed 7 months ago

JoostBuitink commented 8 months ago

Issue addressed

Fixes #208, but needs https://github.com/Deltares/hydromt/issues/731 to be fixed in order to work.

Explanation

Implemented a NoDataStrategy that ignores errors for the optional setup function (lakes, reservoirs, glacier and gauges). Now a warning is returned (in stead of an error), similar to the old behavior of hydromt_wflow. However, as the NoDataStrategy is currently incomplete in HydroMT-core, we need https://github.com/Deltares/hydromt/issues/731 to be fixed before this fix works.

Checklist

JoostBuitink commented 7 months ago

Stable tests are failing, because I believe that they do no yet use the latest version of hydromt (v0.9.3).

Starphire1 commented 7 months ago

I'm excited about a new release. It would be great to have water level management and inflow/outflow calculations for lakes/reservoirs (if possible). It would also be nice if the created toml file at model build stage includes, e.g. lake = "wflow_lakelocs" and reservoir = "wflow_reservoirlocs" to reduce a manual model build step. The reservoir model build has been an exciting new addition to the model. Thanks for all the updates!