search

Deltares / hydromt_wflow

Wflow plugin for HydroMT
https://deltares.github.io/hydromt_wflow/
GNU General Public License v3.0
15 stars 13 forks source link

Release hydromt_wflow v0.5.0 #237

Closed JoostBuitink closed 6 months ago

JoostBuitink commented 6 months ago

Given the latest improvements and fixes (mainly the switch from .ini to .yml files, and improved dealing with the NoDataStrategy) I think it would be good to do a release soon. The switch from .ini to .yml is a relatively big change for our users, hence I think a new major version is a good signal.

At least these two PRs (https://github.com/Deltares/hydromt_wflow/pull/227 and https://github.com/Deltares/hydromt_wflow/pull/229) should be included before we release

Just for completeness, for https://github.com/Deltares/hydromt_wflow/pull/229, we need to fix hydromt to >=0.9.3,<0.10 when we do the release.

Are there any other fixes that we want to include for this release? I'd prefer to release as soon as possible, as it once again allows users to use the same build.yml file regardless of whether the region contains lakes/reservoirs/glaciers.

hboisgon commented 6 months ago

Agreed that it would be nice if these two PRs are merged! Note that the new templates don't yet fix the soilgrids version until this PR and a similar one for artifact data will be merged in core: https://github.com/Deltares/hydromt/pull/718 But we can decide to do a minor release when both PRs are merged on hydromt side?

hboisgon commented 6 months ago

It's a quick docs one but maybe also include #238