Setup KsatHorFrac - Githubissues

Deltares / hydromt_wflow

Wflow plugin for HydroMT

https://deltares.github.io/hydromt_wflow/

GNU General Public License v3.0

15 stars 13 forks source link

Setup KsatHorFrac #249

Closed dalmijn closed 5 months ago

dalmijn commented 6 months ago

Issue addressed

Fixes #228

Explanation

Made setup method and a workflow function. Added a wflow specific catalog for wflow specific data.

Checklist

[x] Updated tests or added new tests
[x] Branch is up to date with main
[x] Tests & pre-commit hooks pass
[x] Updated documentation if needed

Additional Notes (optional)

Added data_catalog should be further discussed. The new ksathorfrac data will be rewritten to a zarr archive. Data should also be added to the artifact data.

hboisgon commented 5 months ago

I see now not all my comments from the first review were resolved and they now appear as outdated. I closed the ones that are outdated but could you also still address the ones that are still open?

dalmijn commented 5 months ago

@hboisgon , this PR became a bit of testing ground for wflow specific catalogs. Although I understand your comments regarding the catalogs and accompanying data, I disagree with some of them to point that I choose to discontinue this PR until we come to a combined discussed design for this (also waiting then for the changes in the core I guess). The pure ksathorfrac setup can be found in this PR #255.