Deltares / hydromt_wflow

Wflow plugin for HydroMT
https://deltares.github.io/hydromt_wflow/
GNU General Public License v3.0
19 stars 15 forks source link

Small I/O fixes #286

Closed dalmijn closed 1 month ago

dalmijn commented 2 months ago

Issue addressed

Fixes number of smaller I/O issues Fixes #276

Explanation

Bit and pieces of code.

Checklist

Additional Notes (optional)

No.

hboisgon commented 1 month ago

I directly changed the PR @dalmijn, hope it's okay. I added some extra things:

All the rest was good, thanks for the changes! If you agree with my last modifications, then we can merge :)

Note, I edited the test on ksathorfrac as nowadays read/write netdcf files can be unstable and cause test to hang. The values are different but this is because as we do not write, the catchment mask is not yet applied.

dalmijn commented 1 month ago

@hboisgon, Ill go over it one last time, but it looks good! Thanks for adding to the PR!