Deltares / imod-python

🐍🧰 Make massive MODFLOW models
https://deltares.github.io/imod-python/
MIT License
16 stars 0 forks source link

SolutionPresets should still require outer_dvclose, inner_dvclose, and inner_rclose; and evaluate arguments more broadly #1019

Open Huite opened 2 months ago

Huite commented 2 months ago

The current presets follow what was written in the MODFLOW 6 documentation. The reason we duplicate these settings is for discoverability, so they are explicitly printed in the IMS file.

However, the outer_dvclose for e.g. the complex preset is 0.1, which is unusably big for almost all our applications. We should always require the users to provide these settings themselves for Simple, Medium, and Complex presets.

It's also worth considering which other arguments should be included exactly. They can always be set via mutations afterwards too.