Deltares / imod-python

🐍🧰 Make massive MODFLOW models

https://deltares.github.io/imod-python/

MIT License

16 stars 0 forks source link

Issue #1020 add allocation first active to elevation #1022

Closed JoerivanEngelen closed 2 months ago

JoerivanEngelen commented 2 months ago

Fixes #1020

Description

Renames first_active_to_riv_bot__drn to stage_to_riv_bot_drn_above
Renames first_active_to_riv_bot to first_active_to_elevation
Update test cases to let drain elevation and ghb head match riv bottom elevation, in this way more some test cases can be removed
Update drn expected results for conductance distribution where the change in drain elevation resulted in differences (crosscut and corrected variants mainly).

Checklist

[x] Links to correct issue
[ ] Update changelog, if changes affect users
[x] PR title starts with Issue #nr, e.g. Issue #737
[x] Unit tests were added
[ ] If feature added: Added/extended example

JoerivanEngelen commented 2 months ago

looks good ( but it would be nice to have a test with a time-dependent river- bottom or stage/elevation)

I added some test cases for rivers with transient info. This covers all possible options for allocation and distrubion. I therefore refrained from adding transient drains, recharge, and GHBs to make the test cases somewhat manageable (cases file already has more than 500 lines).