Deltares / imod-python

🐍🧰 Make massive MODFLOW models
https://deltares.github.io/imod-python/
MIT License
16 stars 0 forks source link

Issue #678 hfb varying top bot #1100

Closed JoerivanEngelen closed 1 day ago

JoerivanEngelen commented 2 weeks ago

Fixes #678

Description

Support horizontal flow barriers with varying ztop and zbottom. Data is set up as vertical polygons, which is also what imod.formats.gen.read_gen() returns. The implementation is based on imod.formats.prj.disv_converter. When we fix the wells, we are feature complete and the disv_converter can be removed.

The use of the vertical dimension means a change in the public API: No longer are the "ztop" and "zbottom" variables in the geodataframe used. Setting up these vertical polygons from scratch is a bit of a hassle, so we could add some utility functions to help setting these up, in a later PR.

Checklist

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud