search

Deltares / imod-python

🐍🧰 Make massive MODFLOW models
https://deltares.github.io/imod-python/
MIT License
20 stars 3 forks source link

Support xarray 2024.10.0 #1271

Open Manangka opened 2 weeks ago

Manangka commented 2 weeks ago

Xarray has been fixed to version 2024.09.0 due to failing unittests. There seems to be 2 kinds of errors

Link to failing build https://dpcbuild.deltares.nl/buildConfiguration/iMOD6_IMODPython_Windows_Tests/5025998?buildTab=overview&expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true&expandBuildProblemsSection=false&expandPull+Request+Details=true

LogFile: Windows_UnitTests_1203.log.zip

JoerivanEngelen commented 2 weeks ago

Thanks for looking into this and posting this issue, to add to this:

If I'm not mistaken, we stored HFB packages in netcdfs as shapely or geopandas data in NetCDFs, this is causing errors with to_netcdf now.

JoerivanEngelen commented 1 week ago

Update: This issue falsely reported dask was at fault, but it was xarray which has been set to avoid 2024.10.0. I therefore took the liberty of altering the title of this issue. Dask works fine, for example see https://github.com/Deltares/imod-python/pull/1280