search

Deltares / imod-python

🐍🧰 Make massive MODFLOW models
https://deltares.github.io/imod-python/
MIT License
17 stars 3 forks source link

add tests for non-equidistant grids #857

Open luitjansl opened 7 months ago

luitjansl commented 7 months ago

Many recently added functions ( clipping, regridding, partitioning, masking) are not tested on non-equidistant grids. We should test what features work and what features don't, and then we can decide what we want to fix and what we won't support for such grids. If we won't support a feature for non-equidistant structured grids we should add a user warning or error message. One way to test all this is to use xugrid (through imod-python functionality) to regrid existing equidistant structured test-models to non-equidistant grids (and while at it, to triangles and voronoi cells ). This last step could reduce the number of models in the testbank significantly, because we would create a single set of structured equidistant test-models and use each model 4 times:

  1. as is
  2. regridded to non-equidistant
  3. regridded to triangles
  4. regridded to voronoi.
JoerivanEngelen commented 7 months ago

Some extra context: Non-equidistant grids were not very commonly applied featured in iMOD5, because performance of its GUI degraded when rendering non-equidistant grids, and the partitioning algorithms for parallel computations in iMOD-WQ and iMODFLOW (quietly) assumed structured grids. We estimate only 5% of the iMOD5 models applied non-equidistant grids.