Deltares / imod-qgis

🗺️🧭 QGIS plugin for iMOD
GNU General Public License v2.0
8 stars 2 forks source link

Current plugin on qgis-plugin repo is broken #23

Closed Huite closed 2 years ago

Huite commented 2 years ago

Due to: https://github.com/Deltares/imod-qgis/issues/22

No actual icons are included in the ZIP on the plugin repo, due to Git LFS. The plugin will start, but on certain widgets it will give an error, as (clearly) no icon can be found.

22 needs to be fixed, and then a new version should be uploaded to the repo.

JoerivanEngelen commented 2 years ago

This was because I downloaded as ZIP from Github to prevent any ignored local files/folders (e.g. pycache) from cluttering the uploaded zip file. However, I was unaware of this setting.

Regardless, the icons are not included in LFS anymore, so I'll upload a new zipfile today.

JoerivanEngelen commented 2 years ago

I added a batch script to package locally, similar to the bash script in the crayfish plugin.

I tested it locally in QGIS and it worked for me. Plugin v0.2.2 is now waiting for approval.