Deltares / ra2ce

RA2CE helps to quantify resilience of critical infrastructure networks, prioritize interventions and adaptation measures and select the most appropriate action perspective to increase resilience considering future conditions.
https://deltares.github.io/ra2ce/
Other
9 stars 2 forks source link

docs: Fixed example due to incorrect paths #459

Closed Carsopre closed 2 months ago

Carsopre commented 2 months ago

Issue addressed

Solves #440

Code of conduct

What has been done?

Correct relative paths throughout the notebook. The previous implementation would only be valid when running under a windows environment.

Checklist

Additional Notes (optional)

Added explicit joinpath instead of / for Pathlib.Path objects.

Carsopre commented 2 months ago

I would expect this will lead to problems with all/most other notebooks as well, as they also use "/" to construct paths.

That's not true, the / is accepted to join paths, .joinpath is simply more explicit and therefore why I modified this one. The jupyter notebooks are standalone examples and it's natural they will differentiate one from the other as code will change with time.