Deltares / ra2ce

RA2CE helps to quantify resilience of critical infrastructure networks, prioritize interventions and adaptation measures and select the most appropriate action perspective to increase resilience considering future conditions.
https://deltares.github.io/ra2ce/
Other
7 stars 1 forks source link

Refactor losses modules #470

Closed ArdtK closed 3 weeks ago

ArdtK commented 1 month ago

Current situation Module losses is called for both analyses SINGLE_LINK_LOSSES and MULTI_LINK_LOSSES (analysis_factory.py). From the execute the module single_link_redundancy or multi_link_redundancy is called, based on the value of analysis.

Potential improvements

Question: what is the function of modules single_link_losses and multi_link_losses atm? They don't seem to be called atm.

ArdtK commented 1 month ago

Discuss with @sahand-asgarpour and @Carsopre

ArdtK commented 4 weeks ago

After discusion with @Carsopre it is chosen to convert Losses into an abstract base class LossesBase, from which single_link_losses and multi_link_losses inherit.