Closed sahand-asgarpour closed 1 month ago
@sahand-asgarpour in NetworkWrapperProtocol
you added method segment_graph
. It is not correct to add implemented methods to a protocol. A protocol is meant to only contain signatures (definitions).
If you would like to have such a method that is used in all implementing classes, you should create a base class next to the protocol.
@sahand-asgarpour in
NetworkWrapperProtocol
you added methodsegment_graph
. It is not correct to add implemented methods to a protocol. A protocol is meant to only contain signatures (definitions). If you would like to have such a method that is used in all implementing classes, you should create a base class next to the protocol.
I understand. Thank you for the clarification. I make an issue for that to be picked up later. Is it an idea?
Just made an issue.
This PR should have not been merged when there's a configuration build failing!
Issue addressed
Solves #136
Code of conduct
What has been done?
Explain how you addressed the resolution of the related issue, what choices you made and why.
Checklist
black
andisort
definitions.master
.Additional Notes (optional)
Add any additional notes or information that may be helpful.