Deltares / rtc-tools

The Deltares toolbox for control and optimization of environmental systems.
GNU Lesser General Public License v3.0
0 stars 2 forks source link

WIP: GP: fix minimization goals #1597

Closed SGeeversAtVortech closed 1 month ago

SGeeversAtVortech commented 1 month ago

In GitLab by @TPiovesan on Jun 17, 2019, 12:06

Fix how minimization goals are created when keep_soft_constraints=False. New reformulation allows for a larger feasible space and a proper application of goal relaxation.

Add unit tests to check how minimization goals constraints and the effect of goal relaxation.

SGeeversAtVortech commented 1 month ago

In GitLab by @vreeken on Jun 19, 2019, 13:56

added 2 commits

Compare with previous version

SGeeversAtVortech commented 1 month ago

In GitLab by @vreeken on Jun 19, 2019, 13:59

@baayen > I'd like to make sure that you didn't deliberately make the decision to exclude the goal order for some reason. To me it make sense (for minimization goals) to set a constraint on the exact thing we solved for, i.e. function**order, and not on just function.

SGeeversAtVortech commented 1 month ago

In GitLab by @baayen on Jun 26, 2019, 13:18

The downside of using function**order in the constraints is that the constraints become non-linear. I would do some testing to make sure that this change does not adversely affect performance of existing models.

SGeeversAtVortech commented 1 month ago

In GitLab by @vreeken on Aug 9, 2019, 15:36

marked as a Work In Progress