WIP: Gp extra checks exceptions #1598

Closed SGeeversAtVortech closed 1 month ago

In GitLab by @vreeken on Jul 24, 2019, 17:11

Previous top commit of !290 (which has now been split into two)

In GitLab by @vreeken on Jul 25, 2019, 16:24

added 6 commits

789169b1...3be1dd2e - 5 commits from branch master
48cec450 - GP: exceptions and additional test for vector goal

Compare with previous version

In GitLab by @codecov on Jul 25, 2019, 16:55

Codecov Report

Merging #292 into master will decrease coverage by 0.19%. The diff coverage is 20%.

Impacted Files	Coverage Δ
...rc/rtctools/optimization/goal_programming_mixin.py	`82.1% <20%> (-1.89%)`	:arrow_down:

In GitLab by @TPiovesan on Sep 6, 2019, 12:52

Commented on tests/optimization/test_vector_goals.py line 129

Why do we want to change this? The situation where function range is a tuple of arrays is already present in the PathGoal1_2_nan class below. For coverage purposes I would leave the tuple of scalar scenario here.

In GitLab by @vreeken on Sep 6, 2019, 13:13

marked as a Work In Progress

In GitLab by @vreeken on Sep 6, 2019, 13:58

For all checks that are added I would expect a test to see if the check hits.

In GitLab by @TPiovesan on Oct 24, 2019, 14:44

closed

Deltares / rtc-tools

WIP: Gp extra checks exceptions #1598

Codecov Report