WIP: adds option to use weights as timeseries in goal_programming_mixin_base #1615

Closed SGeeversAtVortech closed 1 month ago

In GitLab by @RSinnige on Jan 27, 2020, 16:09

Adds option to use weights as timeseries in goal_programming_mixin_base next to the use of scalar goal weights. Scalar goal weights should be positive, while timeseries-values should be nonnegative.

TODO:

write function to make the correct constraints.

resolves #1038

In GitLab by @vreeken on Jan 28, 2020, 17:01

Commented on tests/optimization/test_goal_programming.py line 1039

Could you also add a working example somewhere, e.g. that the result of weight = 1.0 is the same as weight = Timeseries(times, 1.0), but different from weight = Timeseries(times, [1.0, 1.1, 1.2, ...])?

In GitLab by @vreeken on Jan 28, 2020, 17:02

Commented on tests/optimization/test_goal_programming.py line 20

Is this a flake thing? If so, please make it a separate commit. If not, please remove this whitespace change.

In GitLab by @vreeken on Jan 28, 2020, 17:03

Commented on src/rtctools/optimization/goal_programming_mixin_base.py line 557

For goal target_min/max we do not enforce that they have the same length. I'm not saying we shouldn't, but maybe we should also just interpolate to be consistent.

In GitLab by @vreeken on Jan 28, 2020, 17:05

Commented on src/rtctools/optimization/goal_programming_mixin_base.py line 555

I'm not sure what we do for target min/max, but to me it makes sense to check that goal.weight is a scalar (or at least not a Timeseries) when it's not a path goal. Otherwise your code below will fail I think.

In GitLab by @vreeken on Jan 28, 2020, 17:05

Commented on src/rtctools/optimization/goal_programming_mixin_base.py line 791

What if goal.weight is a Timeseries, but the goal is not a path goal?

In GitLab by @RSinnige on Jan 29, 2020, 14:30

Commented on tests/optimization/test_goal_programming.py line 20

changed this line in version 2 of the diff

In GitLab by @RSinnige on Jan 29, 2020, 14:30

added 4 commits

8b1484fb - removes added empty line in test_goal_programming
2a30fc69 - adds additional tests in test_goal_programming
56a12a51 - adds exception for length of timeseries greater than 1 when not using pathgoals
ee092b78 - adds tests which compare results between optimizations with goals

Compare with previous version

In GitLab by @RSinnige on Jan 29, 2020, 14:39

added 1 commit