search

Deltares / rtc-tools

The Deltares toolbox for control and optimization of environmental systems.
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Draft: read in changes to parameters in set_parameter #1632

Open SGeeversAtVortech opened 1 month ago

SGeeversAtVortech commented 1 month ago

In GitLab by @Ailbhemit on Aug 4, 2023, 10:40

The parameters definition is cached and thus edits to parameters made by set_parameter function were not picked up. These lines check with the stored parameter values and update these of needed.

SGeeversAtVortech commented 1 month ago

In GitLab by @Ailbhemit on Aug 4, 2023, 10:40

requested review from @SGeeversAtVortech

SGeeversAtVortech commented 1 month ago

In GitLab by @SGeeversAtVortech on Aug 4, 2023, 11:29

Commented on src/rtctools/data/storage.py line 276

I would expect that this function does not change values, only returns values. Why do we need to update the ensemble size here?

SGeeversAtVortech commented 1 month ago

In GitLab by @jarsarasty on Sep 12, 2023, 11:48

Commented on src/rtctools/data/storage.py line 276

Hi @Ailbhemit, are there any updates on this MR?

Ailbhemit commented 1 month ago

In GitLab by @jarsarasty on Sep 12, 2023, 11:48

Commented on src/rtctools/data/storage.py line 276

Hi @Ailbhemit, are there any updates on this MR?

We found a work around in models to just set with io parameters and call io parameters directly.