Deltares / rtc-tools

The Deltares toolbox for control and optimization of environmental systems.
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Add a SeedMixin class for seed options #1642

Open SGeeversAtVortech opened 2 weeks ago

SGeeversAtVortech commented 2 weeks ago

Add a SeedMixin class for enabling seed options such as reading a seed from a file and falling back to a default seed if the solver failed.

Ailbhemit commented 1 week ago

I am also not able to see how a user can choose whether or not to use a seed based upon and input parameter? Parameters are not yet available when seed_options is accessed.

SGeeversAtVortech commented 1 week ago

I am also not able to see how a user can choose whether or not to use a seed based upon and input parameter? Parameters are not yet available when seed_options is accessed.

The user can overwrite the seed_options method, similar to how we handle other options. By default, option seed_timeseries is None, which means no timeseries is used for the seed.

Ailbhemit commented 1 week ago

I am also not able to see how a user can choose whether or not to use a seed based upon and input parameter? Parameters are not yet available when seed_options is accessed.

The user can overwrite the seed_options method, similar to how we handle other options. By default, option seed_timeseries is None, which means no timeseries is used for the seed.

This is now possible (accessing parameters) with the recent commit