Fix #206. Deal with review comments - Githubissues

Deltares / xugrid

Xarray and unstructured grids

https://deltares.github.io/xugrid/

MIT License

64 stars 8 forks source link

Fix #206. Deal with review comments #207

Closed JoerivanEngelen closed 8 months ago

JoerivanEngelen commented 8 months ago

Fixes: https://github.com/Deltares/xugrid/issues/206, related to: https://github.com/Deltares/xugrid/issues/205

Unfortunately, I accidently pushed my changes to main. @Huite reviewed the changes via chat. This PR is to deal with these review comments.

PR implements the following:

__eq__ can be removed, as it is not equivalent to the pandas behavior
.identical can be renamed to .equals and original .equals can be removed
If else structure is reordered in .equals, to make it more comprehensible
to_xr_if_possible() is removed as it was unnecessary