fix path deprecation warning

Deltares / xugrid

Xarray and unstructured grids

https://deltares.github.io/xugrid/

MIT License

53 stars 8 forks source link

fix path deprecation warning #247

Closed savente93 closed 4 weeks ago

savente93 commented 1 month ago

Use of path as a context manager is deprecated and leads to a warning. In this case, just assigning the variable directly, solves the problem.

savente93 commented 1 month ago

Fixes #244

Huite commented 1 month ago

Great, thanks!

The build step is expected to fail (bit annoying -- I'll open an issue). The failure on py312 is a weird matplotlib tcl thing which I see every so often. I'll try re-running it now.

savente93 commented 4 weeks ago

Seems like the build is failing on a permission error, so I don't think that's something I can do anything about. Could you have another look? (or let me know next steps for me if there are any)

Huite commented 4 weeks ago

Right, sorry for the delay. I reran it for the py312 failure, which looks okay now, but didn't get to merging. Thanks for the ping, merged it now.