search

Deltares / xugrid

Xarray and unstructured grids
https://deltares.github.io/xugrid/
MIT License
65 stars 8 forks source link

Use a FILL_VALUE=-1 everywhere #299

Closed Huite closed 2 months ago

Huite commented 2 months ago

The external fill value is only used when converting back to dataset.

Fixes #298

(Should've done this long ago, there was more than one place where a fill value != -1 might have resulted in an error.)

The error of #298 makes the last release unfortunately quite broken for datasets where a fill_value != -1 was used.

@veenstrajelmer, you might want to run the dfm tools tests with this as well. The fill values were used in a lot of places, it's possible the xugrid test still have some soft spots. If there are any failures, we should patch them and add them as new tests.

Huite commented 2 months ago

I think the previous release is basically half-broken, I was even thinking of whether we should yank it from conda-forge and pypi. But if we release this quickly, that might not be needed since no one will end up getting the previous one installed.