nus-pe-script
commented
12 months ago Team's Response
Please refer to our explanation in the duplicate issue.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Different roles but same name not allowed
There could be a doctor and a patient with the same name but the application does not allow for it. On the same note, if a doctor/nurse becomes a patient, there is no way for the application to handle it as it does not support editing roles or having multiple roles for a user.
[original: nus-cs2103-AY2324S1/pe-interim#237] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Hi tester, we intentionally designed it such that names are case-sensitive and that it must be unique, so that duplicate entries will not be entered. One problem we will face if we allow for such duplicates is during the addition of affiliations. If we ever have a nurse and a doctor named "May Ho" for example, then if a patient wants to add "May Ho" as an affiliation, there will be confusion as to which "May Ho" to add.
In general, we feel that two patients having the exact same name (first, last and middle) is quite a rare case, and so handling these cases is less important than ensuring that the application does not have bugs resulting from duplicate entries in the list.
However, we do agree this is a restriction that we can potentially expand using more complex logic. Unfortunately, this is not within the scope of our course, as rectifying this is less important than what has been done already:
As such, we believe it is a potential implementation for the future.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Does not allow to add doctors/nurses as patients. Sometimes doctors and nurses may be patients, which should be added the database. Perhaps could make doctors/nurses an exception or allow doctor and nurses role to be a patient as well.