DeltonCheng / pe

0 stars 0 forks source link

Unable to see affiliation history after removing a person from addressbook #4

Open DeltonCheng opened 1 year ago

DeltonCheng commented 1 year ago

After removing a person from the address book, the person is also removed from the affiliation history of those that used to be affiliated to them (was removed from affiliation). By using the word 'history', a user would think that it will record all of past affiliations.

Saw that in UG that any association will be removed after using delete, however after removing the affiliation, there should not be an association.

I understand that there may be some difficulty in implementing this, hence rated it low. If it is the intended effect, could perhaps be clearer in the UG in the affiliation history section and delete section!

Before removing Irfan: (Alex Yeoh's affiliation history)

Screenshot 2023-11-17 at 4.47.54 PM.png

After:

Screenshot 2023-11-17 at 4.48.10 PM.png

nus-pe-script commented 12 months ago

Team's Response

You are absolutely right that the idea of 'history' should entail any form of past affiliations even when deleted. Due to the lack of implementation time, we rationalised that for a person to be in the history, they should at least be present in the contact list i.e. still in the hospital, to be useful. If the patient has already left the hospital, then there is no need to track the person in a doctor's/nurse's history.

As such, in v1.4, the way for affiliation history to be useful would be when the affiliation of a person is altered using the edit command. That way, affiliation history will be retained, while at the same time, people in the history will still be present in the contact list.

We did indicate in our UG that deleting a person will remove the person from any affiliation and affiliation history:

image.png

We also talked about it in the DG regarding the potential implementation of saving deleted people in affiliation history:

image.png

We agree with you that retaining the history of a deleted person is definitely a good implementation for the future development of the app!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]