Delusoire / spicetify-extensions

Practical Spicetify Extensions
22 stars 1 forks source link

Sort-plus acting weird #15

Closed Switchbladd closed 11 months ago

Switchbladd commented 11 months ago

I just started using Spicecify and installed like 20+ apps/snippets/extensions and the only extension that does not work as intended is sort-plus. I tested it on 13 song playlist and every time I try to sort it by any parameter it adds all the songs to the queue in the same order as they are in a playlist (meaning it doesn't sort anything) and even more, it adds it like multiple times, 5 or 6 (of every song). Sometimes nothing happens, no errors, no queue, no notifications, nothing. I've already tried reinstalling Spicetify, clean reinstalling Spotify, reinstalling extension multiple times, and reloading a PC, I even tried to run a virtual machine and downloaded Spotify and Spicetify on it and it still behaves the same which is odd because no one else seems to have this problem... image The only thing that I didn't try is using another Spotify account but I doubt it has something to do with it... Edit: and I've obviously tried different playlists

Delusoire commented 11 months ago

That happens because the queue context is set after the tracks are queued, and triggers the Spotify internals to make an infinite repeating context-queue (kind of like playing from any context). I can move the the setQueue to happen after the context is changed, although that's how I originally wrote it and I can only remember that it broke something else. I'll do some testing and see if it's stable now.

Switchbladd commented 11 months ago

Well, it seems like you fixed multiple-adding thing but the sorting itself is still not working for me, is that a problem on my side? Do you have any suggestions on what could cause that? When I try to sort by popularity or true shuffle it simply adds the whole playlist to the queue without any changes (in the same order that it goes in the playlist) while the other 4 parameters (last fm ones and play count) do nothing at all, no notifications, no queue

Delusoire commented 11 months ago

I can't seem to reproduce your error, can you show your console logs/errors? To open devtools you need to run spicetify enable-devtools in the shell, and then hit ctrl + shift + i in the Spotify window.

Switchbladd commented 11 months ago

Sort by play count (nothing happens) - image True shuffle (adds song to queue but does not randomize them) - image Did clean install of both Spotify and Spicetify with no other extensions etc. enabled

Delusoire commented 11 months ago

You're not on the latest Spotify/Spicetify version, just to confirm what happens when you type Spicetify.Snackbar, Spicetify.Snackbar.enqueueSnackbar, Spicetify.Snackbar.updater.enqueueSetState in the console?

Switchbladd commented 11 months ago

image Spotify downloaded from their site and Spicetify downloaded using https://spicetify.app/docs/getting-started/ powershell commands

Delusoire commented 11 months ago

This is what it's supposed to look like: image Can you post a screenshot of your: three dots on the top left => Help => About Spotify ?

Switchbladd commented 11 months ago

image

Delusoire commented 11 months ago

It seems like you're on a newer Spotify version than me. I guess I'm still not elligible for the update, but when I do recieve it i'll add support for 1.2.26.

Switchbladd commented 11 months ago

What is your version? I'll rollback mine

Delusoire commented 11 months ago

It's 1.2.25.1011

Delusoire commented 11 months ago

A Spicetify update was pushed, fixing Snackbar exposure. So now if you update your spicetify everything should be working fine.