Closed onequid closed 1 year ago
Hi. Thanks for opening this PR. Electron 23 just came out and I'm willing to merge this PR to keep that version up-to-date πThe Vue CLI was indeed an unused dev dependency, so removing it makes sense.
Locally I'm running against some issues when upgrading to Electron ^23.0, as Electron outputs the following error:
[electron] Hello from App.vue!
[electron] [55344:0213/224634.753:ERROR:cert_issuer_source_aia.cc(34)] Error parsing cert retrieved from AIA (as DER):
ERROR: Couldn't read tbsCertificate as SEQUENCE
ERROR: Failed parsing Certificate
I don't have this issue on Electron < 23.0. I'm curious what's going on; I haven't found any related Electron issues yet on their GH. So I want to do a little bit more digging on what's causing this before merging π
Hi Dueluze, thanks for your comment. Your views make perfect sense! Cheers! π― And it seems a certificate issue as the message shows. I haven't got this notification yet, so sorry for no clues. Will clean the node_modules make any progress as it comes first to my thought?
I believe the error is coming from trying to load the Vue logo. Loading in other external assets seem to work just fine. I'll update this template to match the project generated by running npm create vite@latest --template vue
@onequid Please run the following commands to update the lock file with these new version changes:
npm install electron@23
npm update vite
npm update vue
After that your PR is able to get merged π
Copy that, Captain.
Glad to make one tiny contribution for this repo π
I will do that ASAP when I get back to my workstation on Monday. Hope that'd be OK.
Hopefully I did it correctly π
Looks good! Thanks for keeping the dependencies up-to-date :)
Vue: 3.2.47 Vite: 4.1.1 Electron: 23.0.0 Closed #43