search

DemandCube / DemandSpike

Load Testing Framework for Distributed Applications
GNU Affero General Public License v3.0
3 stars 5 forks source link

DemandSpike - Add Statistics Gathering from Kafka Random Byte Write #70 #1

Closed louzar closed 10 years ago

smorin commented 10 years ago

Before we can commit please update the project to build with http://www.gradle.org/ and use gradle to include all jar dependencies. Please specify the versions of the jars that it uses.

smorin commented 10 years ago

Update the package names from things like: com.demandspike.kafka.producer to com.demandcube.demandspike.kafka.producer

smorin commented 10 years ago

Remove the build directory and all build files

smorin commented 10 years ago

Add paths that need to be removed to .gitignore

Please in the future for all future projects: don't checkin jars (unless you can't get them from gradle) don't checkin build directories don't checking classes don't checkin hidden files.

This is bad practice

smorin commented 10 years ago

@louzar I haven't seen responses to any of these comments? Can you please address them all? Also haven't seen updates to the pull request to fix these problems. Have you tried to fix them?

louzar commented 10 years ago

new pull request : https://github.com/DemandCube/DemandSpike/pull/2

smorin commented 10 years ago

This wasn't fixed in this pull request