Demigiant / dotween

A Unity C# animation engine. HOTween v2
http://dotween.demigiant.com
Other
2.33k stars 348 forks source link

DOTween as a package #586

Open bdovaz opened 2 years ago

bdovaz commented 2 years ago

@Demigiant Please check everything to see if it is working as it should. I have done checks but you know DOTween better than I do.

I have tried to order this PR in several commits and I have changed what is strictly necessary in *.cs files in order not to complicate this PR more. Once this PR is merged, other changes can be made.

I have developed more functionalities:

Package

When we merge this PR, we should be able to install the package as follows temporarily until it is published in OpenUPM:

"com.demigiant.dotween": "https://github.com/Demigiant/dotween.git?path=/Package#v1.2.632-upm"

DOTween and DOTweenEditor Projects

Asset vs Package

CI Workflow

You can set it as a check when creating PRs so that they must be validated with this worflow in order to be merged.

Other

Edited (25/07/2022):

Added the following:

In general I see that the repository is a bit disorganized with many files that in theory should be in one place but then they are not (references to DOTween Pro code) and it complicates everything a lot... I think you should have divided the repositories in 2 (free and pro) because without this PR nobody can build anything without spending time to remove references to DOTween Pro and it's quite a mess. As far as possible I'm helping to make at least the free part buildable by anyone and above all, through the workflow.

Eyap53 commented 2 years ago

Such a huge work ! Would love to see this merged, so that this package could be used as a dependency for others.

Thanks for that :)

tgoessler commented 1 year ago

I would also appreciate if this could be integrated, because this makes it much easier to provide packages which depend on dotween.

simonpham commented 1 year ago

@Demigiant please take a look Thank you for your time!

4rcant commented 1 year ago

@Demigiant please can we have some traction on this? thanks!!!

danielkreitsch commented 9 months ago

@Demigiant I am in the process of migrating all my projects to UPM. As DOTween is a great tweening engine and I would like to continue using it, I would be happy if this pull request is merged.

Eyap53 commented 9 months ago

@Demigiant I am in the process of migrating all my projects to UPM. As DOTween is a great tweening engine and I would like to continue using it, I would be happy if this pull request is merged.

In the meantime, you may be interested in https://github.com/jeffreylanters/unity-tweens. I tried it and it is very similar, but has updates and UPM

gamebuildio commented 8 months ago

Is there any news on whether this will be merged anytime soon?

Eyap53 commented 8 months ago

See https://github.com/Demigiant/dotween/issues/251#issuecomment-1780753609 for latest update from @Demigiant