search

Demigiant / dotween

A Unity C# animation engine. HOTween v2
http://dotween.demigiant.com
Other
2.3k stars 346 forks source link

[Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks param #589

Closed floky closed 9 months ago

floky commented 1 year ago

At one point, Complete( ) methods on tweens/sequences received an extra super-useful param "withCallbacks". 🎉

Considering that Kill( ) and KillAll( ) methods have the option to also complete the tweens, I think it would be a great API consistency improvement to also have the "withCallbacks" param added to the killing methods.

What do you think? 🤔

Demigiant commented 1 year ago

Yoyooo!!! Very good point, adding it to my todo list :)

floky commented 1 year ago

Yoyooo!!! Very good point, adding it to my todo list :)

😁 it's no big observation, but more of a quality of life improvement. 🤗