DemigodsRPG / Demigods3

The (now defunct) Demigods RPG experience for survival/PvP Minecraft servers.
http://www.demigodsrpg.com/
MIT License
4 stars 2 forks source link

Finish forsaking option refuses to clear once choosen, even after actually forsaking. #186

Closed HmmmQuestionMark closed 10 years ago

alexbennett commented 10 years ago

This was due to calling character.remove() first when forsaking which kicks the player and basically negates everything following. Check around line 1410 and down in the Prayer.java class. I'm not sure why the other stuff is there (like saying "You are free from the will of X." and what-not) if the player gets kicked anyway.. surely I did that for a reason... lol. It's almost as if we didn't kick the player upon character removal before, but I don't know why we wouldn't have. Odd.

Anyway I added I fix for this, but also a TODO, so check that and see what you think.