search

Demion / nodevfee

NoDevFee Ethereum Miner Stratum Protocol DevFee Remover (Redirector)
170 stars 45 forks source link

SSL Connections #40

Open TheTexasMiner opened 6 years ago

TheTexasMiner commented 6 years ago

Question

Does your NoDefFee work with SSL Connections to a pool ? Probably a dumb question, I am thinking that it won't work through SSL.

Demion commented 6 years ago

Starting from 11.1 devfee use SSL encryption. No solution so far.
More details here - https://github.com/Demion/nodevfee/issues/34#issuecomment-370114352.

DragonKingz commented 6 years ago

im using claymore 11.2 + nodevfee v0.2.6b mining on ethermine, asia1 :4444 (not using ssl), still working after i put -allpools 1 :) 1520527399394

TheTexasMiner commented 6 years ago

Claymore is now using the secure ssl :5555 connection for the devfee starting with 11,3. So, even if you use the non secure connection :4444 Claymore devfee is using the :5555 for all the devfee connections. This means that you cannot avoid the devfee if using 11.3 or above. Smart of them, not good for nodevfee.

jsm0 commented 6 years ago

Still no problem running 11.3 on nanopool with divert

TheTexasMiner commented 6 years ago

Does nanopool have the ssl connection at this time ?

newtoopensuse commented 6 years ago

11.3 actually succeeds in thwarting divert. It seems to know divert is working, so it stops processing shares. I observed that devfee had no shares three times in a row when nodevfee or divert was running. I have stopped using them with claymore 11.3 and 11.4. I mine on nanopool, so ssl isn’t a problem.

jsm0 commented 6 years ago

@newtoopensuse This is false. I have tried every newer version of claymore, still using divert 3.x on nanopool. Did you actually check your logs to see if any shares were found during that devfee time? On my 13 gpu rig I consistently get shares every hour as well as my calculated (24hr avg) being +/- of reported. I can confirm divert works all the way to current 11.5. SSL is the problem others on ethermine face.

Nickduino commented 6 years ago

There's too much confusion between nodevfee and divert here.

Demion commented 6 years ago

nodevfee and divert do exactly same thing - replace devfee wallet in network pool authorization packet.

nodevfee - use DLL injection and WinApi functions splicing hooks. divert - use WinDivert driver which use Windows Filtering Platform to capture and modify network packets.

There are reports dll injection / api hook method result in lower efficiency starting from 10.6 or 11.0 version.

Starting from 11.1 ethermine devfee use SSL encryption. There is no solution so far. If you manage to make it work on other pool (nanopool for instance) for both main and devfee then it should be fine (-allpools 1 -retrydelay 1). Only way to tell if it is working is to monitor your actual effective hashrate on your pool statistics for 24 hours (better more).

@newtoopensuse

You only see 2nd worker (default / empty) when devfee finds share it is determined by luck, so it is random (it may not find any for few times in a row). Only way to determine if it is working by logs and, as I were saying, your actual effective hashrate on pool statistics (less then 24 hours may be inaccurate).