Change string handling - Githubissues

Demizo / Daily_You

Every day is worth remembering...

GNU General Public License v3.0

112 stars 5 forks source link

Change string handling #52

Open blaugrau3001 opened 8 months ago

blaugrau3001 commented 8 months ago

Maybe change the way you work with strings, so that you have a strings.xml or something like this. This makes everything more organized and you could easily translate everything to make the app more user friendly. I would do a Pull request, but I am not familiar with dart

I could help you with the german translation.

Demizo commented 8 months ago

This is a good idea. Just from a maintainability perspective I have missed some strings when changing terminology. This is a good step towards issue #30

blaugrau3001 commented 8 months ago

This is a good idea. Just from a maintainability perspective I have missed some strings when changing terminology. This is a good step towards issue #30

I made a German translation of the /fastlane/metadata/android/ is there a way to create a pull request or something like this to help with translation. So there could be more people who understand the app content?

Demizo commented 8 months ago

Woah! I appreciate it! Is it frowned upon to have a German (or whatever language) app store translation without the app supporting that language currently? In other words, should I not add your translation until I have translations in the app itself?

I will create a guide for this process as part of the translation effort, but here is how you could add your translation:

Clone the repo and make a branch
Under fastlane/metadata/android/ create a new folder de (the language code for German)
Add your translated files into that folder (you can use the files/filenames in the en-US folder for reference)
Submit the PR!

blaugrau3001 commented 8 months ago

I think that you configure the repo, because I can't create a PR because I am not able to publish my branch cause no write permissions or something like that

Demizo commented 8 months ago

I think that you configure the repo, because I can't create a PR because I am not able to publish my branch cause no write permissions or something like that

That's my bad! I gave you bad instructions. You need to fork the Repo first. Then you can clone your fork, make the branch, and make the changes. From your fork of the repo you can make a Pull Request into my repo (the origin). Once again, don't feel obligated to do this. I can set up a quick form or something to enter text translations for the app store metadata if you'd prefer.