Rename "kick" to "neutral heavy"

[flip40]

Just rename everything that we have named kick into heavy attack. Just making it generic as it is Sanji's heavy attack. More important for the code pieces (Character.kick() and by extension Sanji.kick() for example), but renaming the other files related would make it less confusing since they would match up.

I am guessing that there will be enough different files that are changed that we might want to do this when there are no open branches to avoid a huge merge conflict, so we will have to find a time (not critical at the moment as well, just makes things nicer when we have multiple characters).

Things that will need to be changed (afaik):

• Animation files
• Animator boolean
• References to the boolean in PlayerMovment
• Character.kick()
• Sanji.kick()
• References to those functions in PlayerMovement
• Hitbox names in HitBoxManager.cs
• Sanji prefab might need to be updated to work with the new file names

[flip40]

Created discussion to help nail this down better in issue #19, we should not do this until that discussion has results as it may effect the naming convention that would be applied to this change.

[ghost]

Is our current moveset fine enough to start on this issue?

Last post here: https://github.com/DemoProductions/fighter/issues/19

[flip40]

I think so, just don't rename the kick folder for animations, when we swap to the new animations in the correctly named folder that problem will solve itself.

[ghost]

We should probably wait on this a little bit longer. More design on other things first in case we end up having to go back and changing a bunch of things

[flip40]

Sure. I think we have the naming conventions fine but I agree that at the moment we have no need to change it immediately. Should be done before implementing a second character, though.

Let me write up a list of names though, so we don't have variations (i.e. neutral heavy vs heavy neutral), I'll add that to #19.