Save the instance before adding to Elections

DemocracyClub / EveryElection

:ballot_box_with_check: For recording every election in the UK

https://elections.democracyclub.org.uk/

BSD 3-Clause "New" or "Revised" License

11 stars 14 forks source link

Save the instance before adding to Elections #2149

Closed VirginiaDooley closed 1 month ago

VirginiaDooley commented 1 month ago

Ref https://democracy-club-gp.sentry.io/share/issue/b06dd1f5d4a14e25b22c2d65aece04ab/

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207407429226442

sentry-io[bot] commented 1 month ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: every_election/apps/elections/admin.py

Function	Unhandled Issue
`save`	ValueError: 'Explanation' instance needs to have a primary key value before this relationship can be used. ... `Event Count:` 5

_{Did you find this useful? React with a 👍 or 👎}

coveralls commented 1 month ago

coverage: 70.706% (-0.02%) from 70.722% when pulling f5a626f65487127ecf0f1bace500ad7273ab4ab2 on hotfix/explanation-needs-primary-key into 8be96fa016d1ae58131790c69f4d083a5776036e on master.

VirginiaDooley commented 1 month ago

Sorry, still a pdb in here

Sorry! Didn't push the fix.