DemocracyClub / WhereDoIVote-Widget

:earth_africa: An embeddable widget that consumes the UK Polling Station API
MIT License
5 stars 4 forks source link

Feature/advanced voting #624

Closed VirginiaDooley closed 2 years ago

VirginiaDooley commented 2 years ago

This work renders the advance voting station when a polling station is available.

http://stagingwidget.wheredoivote.co.uk/feature/advanced-voting/dc/index.html Test with AA12AA

github-actions[bot] commented 2 years ago

This PR has been deployed.

symroe commented 2 years ago

I really like this!

A few things to work on, but should be simple:

VirginiaDooley commented 2 years ago

Re: headings - there are some custom styles that are manipulating heading sizes. After changing the headings as requested, h2s appear smaller than h1s.

symroe commented 2 years ago

Re: headings - there are some custom styles that are manipulating heading sizes. After changing the headings as requested, h2s appear smaller than h1s.

Do you mean bigger than h1? That's what I'm seeing anyway. Can you keep the h1s as are, but make the h2s smaller, on both brands?

symroe commented 2 years ago

Sorry one FINAL minor point!

Can you remove the h2 from inside the caption on the table, and then make the caption CSS not bold (.ds-table caption).

I know this isn't what's done in the design system, but I think it's looking too big in the context of the widget. As per: Screenshot from 2022-04-21 14-08-07