search

DemocracyClub / dc_base_theme

🎨 Democracy Club Base Theme
0 stars 7 forks source link

Form Validation Issues #33

Closed symroe closed 6 years ago

symroe commented 6 years ago

https://github.com/DemocracyClub/UK-Polling-Stations/pull/1137#issuecomment-372765566

symroe commented 6 years ago

Error styles updated to reflect the GDS guidance.

The error at the top of the postcode form is a little much for me, but I trust that the folk at GDS have tested and worked out the trade-offs. I know that in observation sessions I've been in, users tend not to notice error messages unless they are very obvious, so I'm inclined to think that this is a good change. Happy to chat it over though.

screenshot 2018-03-14 12 22 12

screenshot 2018-03-14 12 14 55

chris48s commented 6 years ago

I'd agree that the top error on postcode form could be toned down a bit, but if you do nothing additional I think this is an improvement over what we had before as it stands.

chris48s commented 6 years ago

:+1: