Fix CI and get tests running again

VirginiaDooley commented 2 months ago

Ref https://app.asana.com/0/1204880927741389/1208159470102405/f

Before starting Django/Python/Postgres upgrades, we had to address failures in CI and pytest. Despite references to pytest in the code, the test suite was not set up as needed. Rather than do that work here before upgrades that would almost certainly require additional changes to pytest, I've removed pytest references and ensured the built-in django test functionality is running tests, including in CI.

I've removed and refactored a few tests that were either using unused code or were no longer relevant. Again, a more comprehensive audit of the existing tests will happen with [Remove dead and unused code from election leaflets].(https://app.asana.com/0/1204880927741389/1208159470102409/f)

I've made some minor package changes, again simply with the intention of addressing conflicts, getting tests and CI to pass, whilst ensure the app still functions, all with the intention of addressing package updates in line with upgrades in the next phase. As noted in the commit history, I've temporarily removed aws-sam-cli as there were more than a few dependency conflicts with the installed version.

chris48s commented 1 month ago

OK. Most of the way there now - a few follow ups but they are minor things. Just to make it clear as this PR is now quite long.

Needs to happen:

Suggestion:

https://github.com/DemocracyClub/electionleaflets/pull/251#discussion_r1763047306

chris48s commented 1 month ago

Side note: I would have found the second round of review on this easier without the force-push mid-review. It is easier to quickly tell "what changed since we last reviewed this?" if we just push new commits and then we can do a force-push to tidy up at the end :pray:

DemocracyClub / electionleaflets

Fix CI and get tests running again #251