search

DemocracyClub / uk-election-timetables

Encapsulates timetable legislation for elections run in the United Kingdom and its devolved administrations. 🗳🕰
MIT License
3 stars 0 forks source link

Update bank holidays #20

Closed Bekabyx closed 1 year ago

Bekabyx commented 1 year ago

Updated to include the additions from the new .gov date list.

Maintained the 2016 dates for the integrity of the tests as they are reliant on this file. This may cause duplicate github issues over the coming days but hoping to have this sorted by next week.

VirginiaDooley commented 1 year ago

Might be worth changing setup.py to grab the version dynamically, helpful to avoid versioning mismatch (I've done this repeatedly).

symroe commented 1 year ago

Thanks for this!

Just to make sure I understand, because the diff on a single line of JSON isn't easy to read!

This is the old file, with the newer dates appended to the end?

I agree with @VirginiaDooley's comment about adding the version to the __init__, that's more in keeping with our other libraries :+1:

Bekabyx commented 1 year ago

@symroe Essentially yes, this is the new dataset + 2016 dates that we held before. I actually patched the old dates into the new .gov file so as not to miss any of the new dates out as they're more essential. I ran it through a json diff tool as a sense check as well.

Implemented the change to version :)