Closed sjorford closed 2 years ago
Done a bit of digging here, and in the database currently we have 65 examples where the party_name
stored on the candidacy is different to the name of the party object attached to the candidacy. I think they are largely correct because they are the results of the party changing their name. However the ones outlined by @sjorford above are incorrect, so I will update these, but I think it might need to be a manual update in a shell.
As to what caused these to be incorrect, it seems that when we initially added the party_name
field to the Membership model (to allow us to store the name of the party at the time of candidacy - mainly to get around the Brexit Party/Reform UK change) there was a bug that meant when changing the party of a candidacy via the "edit a person" page did not update the party_name
field. This can be seen by looking at the last change here where the party was changed from Independent to Count Binface Party, but as described in the issue the party name stored was still "Independent". I've tested this locally and the bug no longer exists, but I am going to add some unit tests to guard against it.
Here is a rough print out of the discrepancies in case there are any others that jump out that need to be updated:
/person/18211/melvyn-jones
local.welwyn-hatfield.hatfield-central.2021-05-06
Party name on candidacy: Abolish the Town Council Party
Current name of party: Abolish the TV Licence Party
/person/18211/melvyn-jones
local.hertfordshire.hatfield-north.2021-05-06
Party name on candidacy: Abolish the Town Council Party
Current name of party: Abolish the TV Licence Party
/person/18211/melvyn-jones
local.welwyn-hatfield.hatfield-south-west.2018-05-03
Party name on candidacy: Abolish the Town Council Party
Current name of party: Abolish the TV Licence Party
/person/8317/irshad-ahmed
sp.r.lothian.2021-05-06
Party name on candidacy: Scottish National Party (SNP)
Current name of party: Alba Party
/person/54892/roger-keech
local.dundee-city.north-east.by.2019-05-02
Party name on candidacy: Citizens First
Current name of party: Citizen's First
/person/72363/count-binface
mayor.london.2021-05-06
Party name on candidacy: Independent
Current name of party: Count Binface Party
/person/68922/lewis-jennings
local.fermanagh-and-omagh.erne-north.2019-05-02
Party name on candidacy: Democrats and Veterans Direct Democracy Party
Current name of party: Five Star Direct Democracy Party
/person/69028/ricky-taylor
local.lisburn-and-castlereagh.lisburn-south.2019-05-02
Party name on candidacy: Democrats and Veterans Direct Democracy Party
Current name of party: Five Star Direct Democracy Party
/person/49181/si-harvey
local.mid-and-east-antrim.carrick-castle.by.2018-10-18
Party name on candidacy: Democrats and Veterans Direct Democracy Party
Current name of party: Five Star Direct Democracy Party
/person/49181/si-harvey
local.mid-and-east-antrim.carrick-castle.2019-05-02
Party name on candidacy: Democrats and Veterans Direct Democracy Party
Current name of party: Five Star Direct Democracy Party
/person/22555/allyson-black
sp.c.falkirk-east.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/54763/joel-bryan
local.derbyshire.duffield-and-belper-south.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/4142/junab-ali
pcc.wiltshire.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/20779/lezley-marion-cameron
sp.c.edinburgh-pentlands.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/7527/rhoda-grant
sp.c.inverness-and-nairn.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/31562/susan-dungworth
local.northumberland.hartley.2021-05-06
Party name on candidacy: Labour Party
Current name of party: Labour and Co-operative Party
/person/20536/charlotte-galsworthy
local.neath-port-talbot.bryn-and-cwmavon.2017-05-04
Party name on candidacy: Plaid Cymru - The Party of Wales
Current name of party: Labour Party
/person/48462/judith-garfield
gla.c.havering-and-redbridge.2021-05-06
Party name on candidacy: Labour and Co-operative Party
Current name of party: Labour Party
/person/73474/sarah-murphy
senedd.c.bridgend.2021-05-06
Party name on candidacy: Labour and Co-operative Party
Current name of party: Labour Party
/person/75737/dave-fraser
local.wigan.leigh-south.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/51050/james-morley
local.wigan.leigh-east.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/51050/james-morley
local.wigan.leigh-east.2019-05-02
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/15394/jayson-hargreaves
local.wigan.leigh-west.2019-05-02
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/15394/jayson-hargreaves
local.wigan.leigh-west.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/41150/julian-david-marsh
local.wigan.tyldesley.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/15328/quinton-john-smith
local.wigan.atherton.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/15328/quinton-john-smith
local.wigan.atherton.2019-05-02
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/51034/susan-ann-davies
local.wigan.atherleigh.2019-05-02
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/75460/zoe-irlam
local.wigan.atherleigh.2021-05-06
Party name on candidacy: Leigh, Atherton & Tyldesley Together
Current name of party: Leigh & Atherton Independents
/person/73036/piers-corbyn
mayor.london.2021-05-06
Party name on candidacy: Independent
Current name of party: Let London Live
/person/72913/brian-rose
mayor.london.2021-05-06
Party name on candidacy: Independent
Current name of party: London Real Party
/person/7222/none-of-the-above-x
parl.south-basildon-and-east-thurrock.2010-05-06
Party name on candidacy: Independent
Current name of party: NOTA
/person/1783/george-hallam
parl.lewisham-east.2010-05-06
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/56089/gwenton-dennis-sloley
local.lewisham.new-cross.by.2021-05-06
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/56089/gwenton-dennis-sloley
local.lewisham.whitefoot.by.2019-05-02
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/6418/helen-mercer
parl.lewisham-deptford.2015-05-07
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/36983/john-nicholas-hamilton
local.lewisham.bellingham.by.2021-05-06
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/36983/john-nicholas-hamilton
mayor.lewisham.2018-05-03
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/39858/joyce-jacca
local.lewisham.evelyn.by.2019-05-02
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/76883/michael-anthony-wayne
local.lewisham.sydenham.by.2021-05-06
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/5700/nick-long
parl.lewisham-east.2015-05-07
Party name on candidacy: Lewisham People Before Profit
Current name of party: People Before Profit
/person/7633/jason-pilley
local.southend-on-sea.st-lukes.2018-05-03
Party name on candidacy: Psychedelic Future Party
Current name of party: Psychedelic Movement
/person/7633/jason-pilley
local.southend-on-sea.leigh.2019-05-02
Party name on candidacy: Psychedelic Future Party
Current name of party: Psychedelic Movement
/person/7633/jason-pilley
parl.rochford-and-southend-east.2019-12-12
Party name on candidacy: Psychedelic Future Party
Current name of party: Psychedelic Movement
/person/41717/david-durant
local.havering.rainham-and-wennington.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/43122/graham-williamson
local.havering.south-hornchurch.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/41729/jeffrey-tucker
local.havering.rainham-and-wennington.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/43119/natasha-anne-summers
local.havering.south-hornchurch.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/43110/philip-peter-bowen
local.havering.south-hornchurch.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/41718/tony-durdin
local.havering.rainham-and-wennington.2018-05-03
Party name on candidacy: Rainham Resident's Association
Current name of party: Rainham Independent Residents Association
/person/13110/ariane-burgess
sp.c.inverness-and-nairn.2021-05-06
Party name on candidacy: Green Party
Current name of party: Scottish Green Party
/person/34990/benjamin-david-weenen
parl.cities-of-london-and-westminster.2017-06-08
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/1842/jon-collings
parl.city-of-durham.2017-06-08
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/5395/mark-wadsworth
local.essex.buckhurst-hill-and-loughton-south.2021-05-06
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/5395/mark-wadsworth
parl.epping-forest.2015-05-07
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/5395/mark-wadsworth
local.epping-forest.buckhurst-hill-west.2016-05-05
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/72343/richard-galloway
local.lewisham.catford-south.by.2021-05-06
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/72343/richard-galloway
parl.lewisham-east.2019-12-12
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/5394/rohen-kapur
parl.folkestone-and-hythe.2019-12-12
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/5394/rohen-kapur
parl.folkestone-and-hythe.2015-05-07
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/34867/thomas-hall
parl.lewisham-east.by.2018-06-14
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/34867/thomas-hall
parl.epping-forest.2017-06-08
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/34867/thomas-hall
local.epping-forest.buckhurst-hill-west.2019-05-02
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/34867/thomas-hall
local.epping-forest.buckhurst-hill-west.2021-05-06
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/34867/thomas-hall
parl.epping-forest.2019-12-12
Party name on candidacy: Young People's Party YPP
Current name of party: Shared Ground
/person/21017/brian-nugent
sp.r.highlands-and-islands.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74390/david-mchutchon
sp.r.north-east-scotland.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74462/andrew-macdonald
sp.r.highlands-and-islands.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74413/ewan-gurr
sp.r.north-east-scotland.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74462/andrew-macdonald
sp.c.inverness-and-nairn.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/21017/brian-nugent
sp.c.shetland-islands.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74390/david-mchutchon
sp.c.banffshire-and-buchan-coast.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/74413/ewan-gurr
sp.c.dundee-city-west.2021-05-06
Party name on candidacy: Restore Scotland
Current name of party: Sovereignty
/person/7290/jane-lawrence
parl.uxbridge-and-south-ruislip.2015-05-07
Party name on candidacy: The Realists' Party
Current name of party: The Motoring Party
/person/7290/jane-lawrence
parl.lewisham-deptford.2017-06-08
Party name on candidacy: The Realists' Party
Current name of party: The Motoring Party
There are a few rows on the CSV that have the incorrect
party_name
:The
party_id
column is correct, and the correct party name is displayed on both Candidates and WCIVF:see also #1521 which may be related