search

DemocracyClub / yournextrepresentative

👥 A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk
GNU Affero General Public License v3.0
21 stars 27 forks source link

Don't allow marking winners if winners are already set or ballot is cancelled #1602

Open VirginiaDooley opened 3 years ago

VirginiaDooley commented 3 years ago

When I'm signed in, and visit a past election where a winner is set, I still have the ability to edit and set winner. Screen Shot 2021-10-07 at 12 59 01 PM

From @symroe:

This is a little complex as we need to check the winner_count on the ballot: we want to show the buttons as long as the set winners are less than the winner count

A related bug: we shouldn't show the buttons when the ballot is cancelled: https://candidates.democracyclub.org.uk/elections/mayor.greater-manchester-ca.2020-05-07/

VirginiaDooley commented 3 years ago

Setting priority as medium only because this is something we can potentially tackle after SOPN related work is complete.